Hi, On Wed, May 30, 2018 at 8:50 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Wed, May 30, 2018 at 07:54:47AM -0700, Doug Anderson wrote: >> On Wed, May 30, 2018 at 3:37 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > >> > I'm confused as to why we are specifying the maximum current the device >> > can deliver in a given mode in the DT - surely that's a fixed property >> > of the hardware? > >> Said another way: you're saying that you'd expect the "max-microamps" >> table to have one fewer element than the listed modes? So in the >> above example you'd have: > > No, I'm saying that I don't know why that property exists at all. This > sounds like it's intended to be the amount of current the regulator can > deliver in each mode which is normally a design property of the silicon. Ah, got it. So the whole point here is to be able to implement either the function "set_load" or the function "get_optimum_mode". We need some sort of table to convert from current to mode. That's what this table does. My argument to David was that since set_load / get_optimum_mode were features of the regulator core these should actually be standard properties and not Qualcomm-specific ones. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
