Hi, On Wed, May 30, 2018 at 8:48 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Wed, May 30, 2018 at 08:34:50AM -0700, Doug Anderson wrote: >> On Wed, May 30, 2018 at 8:02 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > >> > What you're describing sounds like what we should be doing normally, if >> > we're not doing that we should probably be fixing the core. > >> I'm not convinced that this behavior makes sense to move to the core. >> On most regulators I'd expect that when the regulator driver says to >> turn them off that they will output no voltage. The reason RPMh is > > Oh, you mean while the regulator is off... TBH I don't see a huge > problem doing that anyway and just reverting to the bottom of the > constraints when everything gets turned off since we have to see if we > need to adjust the voltage every time we enabled anyway. > >> In any other system when Linux disabled the regulator it wouldn't >> matter that you left it set at 1.4V. Thus RPMh is special and IMO the >> workaround belongs there. > > Without the core doing something the regulator isn't going to get told > that anything updated voltages anyway... I was just suggesting that when the core tells the regulator driver to disable itself that the regulator driver tell RPMh to not only disable itself but also (temporarily) vote for a lower voltage. When the core tells the regulator to re-enable itself then the regulator driver restores the original voltage vote (or applies any vote that might have been attempted while the regulator was disabled). That wouldn't require any regulator core changes. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
