* Faiz Abbas <faiz_abbas@xxxxxx> [180530 14:12]: > The dra76x MCAN generic interconnect module has a its own > format for the bits in the control registers. ... > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > @@ -1262,6 +1262,22 @@ static const struct sysc_capabilities sysc_omap4_usb_host_fs = { > .regbits = &sysc_regbits_omap4_usb_host_fs, > }; > > +static const struct sysc_regbits sysc_regbits_dra7_mcan = { > + .dmadisable_shift = -ENODEV, > + .midle_shift = -ENODEV, > + .sidle_shift = -ENODEV, > + .clkact_shift = -ENODEV, > + .enwkup_shift = 4, > + .srst_shift = 0, > + .emufree_shift = -ENODEV, > + .autoidle_shift = -ENODEV, > +}; > + > +static const struct sysc_capabilities sysc_dra7_mcan = { > + .type = TI_SYSC_DRA7_MCAN, > + .regbits = &sysc_regbits_dra7_mcan, > +}; > + > static int sysc_init_pdata(struct sysc *ddata) > { > struct ti_sysc_platform_data *pdata = dev_get_platdata(ddata->dev); > @@ -1441,6 +1457,7 @@ static const struct of_device_id sysc_match[] = { > { .compatible = "ti,sysc-mcasp", .data = &sysc_omap4_mcasp, }, > { .compatible = "ti,sysc-usb-host-fs", > .data = &sysc_omap4_usb_host_fs, }, > + { .compatible = "ti,sysc-dra7-mcan", .data = &sysc_dra7_mcan, }, > { }, > }; Looks good to me. And presumably you checked that no other dra7 modules use sysconfig register bit layout like this? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html