Re: [PATCH 3/3] ASoC: simple-card: add support for clock divider setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, May 29, 2018 01:35 PM, Mark Brown wrote:
On Mon, May 28, 2018 at 09:35:03PM +0200, Daniel Mack wrote:
Add support to call into snd_soc_dai_set_clkdiv() for both CPU and codec
DAIs from simple-card's hw_params().

This allows platforms to set hardware-specific values without providing an
own machine driver.

Why do we have anything that actually needs this?  The devices with a
set_clkdiv() operation are pretty legacy at this point and most of them
should just be figuring out the dividers for themselves anyway.

The PXA platform CPU DAI still has it, and grepping also reveals some Freescale and Samsung platforms.

If that's considered legacy, we shouldn't add bindings for it of course. I can look into the PXA driver and see if it can auto-detect the dividers itself. It won't be straight forward though as the clocking setup also depends on configurations such as TDM slots, external vs. internal clocks etc. Meh.


Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux