On 05/28/2018 10:47 AM, Linus Walleij wrote:
> The Realtek SMI family is a set of DSA chips that provide
> switching in routers. This binding just follows the pattern
> set by other switches but with the introduction of an embedded
> irqchip to demux and handle the interrupts fired by the single
> line from the chip.
>
> This interrupt construction is similar to how we handle
> interrupt controllers inside PCI bridges etc.
>
> Cc: Antti Seppälä <a.seppala@xxxxxxxxx>
> Cc: Roman Yeryomin <roman@xxxxxxxx>
> Cc: Colin Leitner <colin.leitner@xxxxxxxxxxxxxx>
> Cc: Gabor Juhos <juhosg@xxxxxxxxxxx>
> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> +
> + mdio {
> + compatible = "realtek,smi-mdio", "dsa-mdio";
You should drop the "dsa-mdio" compatible string here since it both non
documented and not matched either.
Other than that, this looks great, with that fixed:
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
