> -----Original Message----- > From: Vinod [mailto:vkoul@xxxxxxxxxx] > Sent: 2018年5月29日 18:21 > To: Wen He <wen.he_1@xxxxxxx> > Cc: dmaengine@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Jiafei Pan > <jiafei.pan@xxxxxxx>; Jiaheng Fan <jiaheng.fan@xxxxxxx> > Subject: Re: [v5 1/6] dmaengine: fsldma: Replace DMA_IN/OUT by > FSL_DMA_IN/OUT > > On 29-05-18, 10:14, Wen He wrote: > > > > > > Well that patch seems to do a bit more than replace DMA_IN/OUT by > > > FSL_DMA_IN/OUT care to explain those. best would be to do a patch > > > which does replace and then add new things in separate patch, easier > > > to review > > > > > > > What does means? > > This also a patch. > > You cna do only replace DMA_IN/OUT by FSL_DMA_IN/OUT in this patch. > Second patch can add additional macros you have added and explain what > they do and why they are needed > Got it, it's good idea. Wen > -- > ~Vinod ?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v??????2??璀??摺?囤??z夸z罐?+?????w棹f