Hi Kieran, On Tue, May 29, 2018 at 11:08 AM, Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote: > On 28/05/18 10:06, Geert Uytterhoeven wrote: >> On Fri, Apr 27, 2018 at 6:57 PM, Kieran Bingham >> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote: >>> The DU1 external dot clock is provided by the fixed frequency clock >>> generator X21, while the DU0 and DU3 clocks are provided by the >>> programmable Versaclock5 clock generator. >>> >>> Enable the clocks, and the HDMI encoder for the M3-N Salvator-X board >>> and hook it up to the HDMI connector. >>> >>> Based on patches from Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> >>> >>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >>> >>> --- >>> v2: >>> - Remove LVDS clocks from DU node >>> - Merge DU Clocks and HDMI enablement >>> --- >>> .../boot/dts/renesas/r8a77965-salvator-x.dts | 28 +++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >>> index 75d890d91df9..340a3c72b65a 100644 >>> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >>> @@ -19,3 +19,31 @@ >>> reg = <0x0 0x48000000 0x0 0x78000000>; >>> }; >>> }; >>> + >>> +&du { >>> + clocks = <&cpg CPG_MOD 724>, >>> + <&cpg CPG_MOD 723>, >>> + <&cpg CPG_MOD 721>, >>> + <&versaclock5 1>, >>> + <&x21_clk>, >>> + <&versaclock5 2>; >>> + clock-names = "du.0", "du.1", "du.3", >>> + "dclkin.0", "dclkin.1", "dclkin.3"; >>> +}; >>> + >>> +&hdmi0 { >>> + status = "okay"; >>> + >>> + ports { >>> + port@1 { >>> + reg = <1>; >>> + rcar_dw_hdmi0_out: endpoint { >>> + remote-endpoint = <&hdmi0_con>; >>> + }; >>> + }; >>> + }; >>> +}; >>> + >>> +&hdmi0_con { >>> + remote-endpoint = <&rcar_dw_hdmi0_out>; >>> +}; >> >> I think the hdmi0 and hdmi0_con parts can be moved to salvator-common.dtsi. >> Can we do that now (with stubs?), or does this have to wait until r8a77965 has >> received HDMI sound support? > > I don't know about the sound integration I'm afraid, but common HDMI connections > would certainly be a benefit I believe. > > Is this something you're looking to tackle? Or would you like > me/Morimoto-san/media team to look at it? Feel free to give it a try. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html