On 23 May 2018 at 22:48, Ivan T. Ivanov <iivanov.xz@xxxxxxxxx> wrote:
> Quoting Rob Herring (2018-05-23 23:29:29)
>> On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@xxxxxxxxxx> wrote:
>> > The ETF input should be connected to the funnel output, and the ETF
>> > output should be connected to the replicator input. The labels are wrong
>> > and these got swapped:
>> >
>> > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional
>> > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional
>> >
>> > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")
>> > Cc: Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx>
>> > Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
>> > Cc: Andy Gross <andy.gross@xxxxxxxxxx>
>> > Cc: David Brown <david.brown@xxxxxxxxxx>
>> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx
>> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>> > ---
>> > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Ping. Still seeing warnings in -next for these.
>>
>
> Hi Rob,
>
> I no longer have access to this hardware and documentation.
> I am sure that Mathieu and friends will take care for verification
> of this patch :-)
The code triggers on the "slave-mode" property rather than the labels,
so this patch has no effect on how a path is established. I've tested
this on a 410c and things look good.
Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
Tested-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
>
> Regards,
> Ivan
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
