On Thu, May 24, 2018 at 02:25:34PM +0100, Robin Murphy wrote: > On 23/05/18 19:10, Guenter Roeck wrote: > >On Wed, May 23, 2018 at 11:57:25AM +0100, Robin Murphy wrote: > >>On 22/05/18 19:47, Ray Jui wrote: > >>>Update the SP805 binding document to add optional 'timeout-sec' > >>>devicetree property > >>> > >>>Signed-off-by: Ray Jui <ray.jui@xxxxxxxxxxxx> > >>>Reviewed-by: Scott Branden <scott.branden@xxxxxxxxxxxx> > >>>--- > >>> Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>>diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>index edc4f0e..f898a86 100644 > >>>--- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>+++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>@@ -19,6 +19,8 @@ Required properties: > >>> Optional properties: > >>> - interrupts : Should specify WDT interrupt number. > >>>+- timeout-sec : Should specify default WDT timeout in seconds. If unset, the > >>>+ default timeout is 30 seconds > >> > >>According to the SP805 TRM, the default interval is dependent on the rate of > >>WDOGCLK, but would typically be a lot longer than that :/ > >> > >Depends on the definition of "default". In the context of watchdog drivers, > >it is (or should be) a driver default, not a chip default. > > DT describes hardware, not driver behaviour. > In this case it describes expected system behavior. Most definitely it does not describe some hardware default. Please note that I do not engage in discussions I consider bike-shedding. This is one of those. Dropping out. Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
