On Wed, May 23, 2018 at 3:27 AM, Daniel Mack <daniel@xxxxxxxxxx> wrote: > On Tuesday, May 22, 2018 07:54 PM, Rob Herring wrote: >> >> On Thu, May 17, 2018 at 11:05:50AM +0200, Daniel Mack wrote: >>> >>> Allow configuring the device as wakeup source through device properties, >>> as >>> not all platforms want to wake up on touch screen activity. >>> >>> The I2C core automatically reads the "wakeup-source" DT property to >>> configure a device's wakeup capability, and board supports files can set >>> I2C_CLIENT_WAKE in the flags. >> >> >> This will break wake-up on working systems. Looks like mostly i.MX, but >> there's one AM437x board. If that board doesn't care, then it is up to >> Shawn. > > > I added the property to the dts files, but as Dmitry pointed out, I missed > some. Sorry for that. Just adding the property to dts files doesn't fix the compatibility problem. If a user uses an existing dtb (before this change) with a new kernel (after this change), then wakeup will stop working. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
