On 05/22/2018 07:22 PM, Rob Herring wrote: > On Mon, May 21, 2018 at 10:07:26AM +0200, Christophe Roullier wrote: >> This patch describes syscon DT bindings. >> >> Signed-off-by: Christophe Roullier <christophe.roullier@xxxxxx> >> --- >> Documentation/devicetree/bindings/arm/stm32.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/stm32.txt b/Documentation/devicetree/bindings/arm/stm32.txt >> index 6808ed9..e46ebad 100644 >> --- a/Documentation/devicetree/bindings/arm/stm32.txt >> +++ b/Documentation/devicetree/bindings/arm/stm32.txt >> @@ -8,3 +8,8 @@ using one of the following compatible strings: >> st,stm32f746 >> st,stm32h743 >> st,stm32mp157 >> + >> +Required nodes: >> +- syscon: the soc bus node must have a system controller node pointing to the >> + global control registers, with the compatible string >> + "st,stm32mp157-syscfg", "syscon"; > > Please don't mix soc/board bindings with other nodes. So perhaps > stm32-syscon.txt. > > Rob > Hi Rob, Is it ok for you with this tree file: Documentation/devicetree/bindings/arm/stm32/stm32.txt Documentation/devicetree/bindings/arm/stm32/stm32-syscon.txt With stm32-syscon.txt: --------------------------------------------------- STMicroelectronics STM32 Platforms System Controller Properties: - compatible : should contain two values. First value must be : - " st,stm32mp157-syscfg " - for stm32mp157 based SoCs, second value must be always "syscon". - reg : offset and length of the register set. Example: syscfg: system-config@50020000 { compatible = "st,stm32mp157-syscfg", "syscon"; reg = <0x50020000 0x400>; }; --------------------------------------------------- Do we need to update also all MCU family (stm32f4, stm32h7, stm32f7) property to be coherent ? Thanks for your feedback. Christophe. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f