Hi Geert, On Wed, 23 May 2018 at 10:12, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Michel, > On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > <michel.pollet@xxxxxxxxxxxxxx> wrote: > > This adds the Renesas RZ/N1D (Part #R9A06G032) SoC bare > > bone support. > > > > This currently only handles generic parts (gic, architected timer) > > and a UART. > > For simplicity sake, this also relies on the bootloader to set the > > pinctrl and clocks. > > > > Signed-off-by: Michel Pollet <michel.pollet@xxxxxxxxxxxxxx> > Thanks for your patch! > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + clocks = <&clock RZN1_DIV_CA7>; > I think the clocks property should be moved to the individual CPU nodes. Ah, I had a look around, and I found some instances that are in the cpu sub-node, and others that are not -- it seems that having it in the cpu sub-node would implies it's core specific... here if that clock is changed both cores would change speed... Either way, it's not used by the kernel in any way at the moment -- I had hoped cpufreq or something would claim it, but it's not the case. Thanks, Michel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html