Hi Sergei, On Fri, May 18, 2018 at 9:45 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Define the generic R8A77980 part of the GEther device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> Thanks for your patch! With the below addressed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -417,6 +417,17 @@ > dma-channels = <16>; > }; > > + gether: ethernet@e7400000 { > + compatible = "renesas,gether-r8a77980"; > + reg = <0 0xe7400000 0 0x1000>; > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 813>; > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; resets = <&cpg 813>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; Any default phy-mode needed? > + }; > + > mmc0: mmc@ee140000 { > compatible = "renesas,sdhi-r8a77980", > "renesas,rcar-gen3-sdhi"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html