On Thursday 17 May 2018 08:39 PM, David Lechner wrote:
> On 05/17/2018 09:35 AM, Sekhar Nori wrote:
>> Hi David,
>>
>> On Wednesday 09 May 2018 10:56 PM, David Lechner wrote:
>>> This adds device tree support to the davinci timer so that when clocks
>>> are moved to device tree, the timer will still work.
>>>
>>> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
>>> ---
>>
>>> +static int __init of_davinci_timer_init(struct device_node *np)
>>> +{
>>> + struct clk *clk;
>>> +
>>> + clk = of_clk_get(np, 0);
>>> + if (IS_ERR(clk)) {
>>> + struct of_phandle_args clkspec;
>>> +
>>> + /*
>>> + * Fall back to using ref_clk if the actual clock is not
>>> + * available. There will be problems later if the real clock
>>> + * source is disabled.
>>> + */
>>> +
>>> + pr_warn("%s: falling back to ref_clk\n", __func__);
>>> +
>>> + clkspec.np = of_find_node_by_name(NULL, "ref_clk");
>>> + if (IS_ERR(clkspec.np)) {
>>> + pr_err("%s: No clock available for timer!\n", __func__);
>>> + return PTR_ERR(clkspec.np);
>>> + }
>>> + clk = of_clk_get_from_provider(&clkspec);
>>> + of_node_put(clkspec.np);
>>> + }
>>
>> Do we need this error path now?
>>
>> Thanks,
>> Sekhar
>>
>
> No, not really.
Then lets just print an error and return the error number.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
