On Tue, May 15, 2018 at 11:20 PM, Stefan Agner <stefan@xxxxxxxx> wrote: > On 15.05.2018 16:41, Krzysztof Kozlowski wrote: >> Colibri-T20 can come in 256 MB RAM (with 512 MB NAND) or 512 MB RAM >> (with 1024 MB NAND) flavors. Both of them will use the same DTSI >> expecting the bootloader to do the fixup of /memory node. However in >> case it does not happen, let's stay on safe side by limiting the memory >> to 256 MB for both versions of Colibri-T20. >> >> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> >> --- >> >> RFT: >> Not tested on 512 MB module as I have only the 256 MB one. >> >> Changes since v3: >> 1. Reduce the memory in existing DTSI instead of creating a new one >> (suggested by Marcel). >> >> Changes since v2: >> 1. Do not add new compatible but use everywhere existing >> "toradex,colibri_t20-512" (suggested by Rob). >> >> Changes since v1: >> 1. Fix memory size in tegra20-colibri-256.dtsi (was working fine because >> my bootloader uses mem= argument). >> --- >> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 9 +++++++-- >> arch/arm/boot/dts/tegra20-iris-512.dts | 2 +- > > I don't like this variant too much. > > Can we not just drop the 512? And while at it, I would prefer to see the > usual $soc-$module-$carrier schema, as we use with all the other modules > of the Colibri and Apalis family. > > e.g. > tegra20-colibri-512.dtsi -> tegra20-colibri.dtsi > tegra20-iris-512.dts -> tegra20-colibri-iris.dts Sure, let me resend it. BR, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
