On 09/05/2018 17:46:10+0200, Amelie Delaunay wrote: > struct stm32_rtc_registers { > @@ -86,6 +98,9 @@ struct stm32_rtc_registers { > u8 prer; > u8 alrmar; > u8 wpr; > + u8 sr; > + u8 scr; > + u16 verr; All those offsets should probably be u16 or u32... > + if (regs.verr != UNDEF_REG) { ...else, this is not working, as reported by kbuild > + u32 ver = readl_relaxed(rtc->base + regs.verr); > + > + dev_info(&pdev->dev, "registered rev:%d.%d\n", > + (ver >> STM32_RTC_VERR_MAJREV_SHIFT) & 0xF, > + (ver >> STM32_RTC_VERR_MINREV_SHIFT) & 0xF); > + } > + -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html