On Fri, 21 Feb 2014 15:16:52 Arnd Bergmann wrote: > On Friday 21 February 2014 17:31:29 Alistair Popple wrote: > > +static const struct of_device_id ohci_of_match[] = { > > + { .compatible = "usb-ohci", }, > > + {}, > > +}; > > + > > > > static const struct platform_device_id ohci_platform_table[] = { > > > > { "ohci-platform", 0 }, > > { } > > > > @@ -198,6 +209,7 @@ static struct platform_driver ohci_platform_driver = { > > > > .owner = THIS_MODULE, > > .name = "ohci-platform", > > .pm = &ohci_platform_pm_ops, > > > > + .of_match_table = ohci_of_match, > > > > } > > > > }; > > Linux-next already has a patch to add an of_match_table in this driver, > using > > static const struct of_device_id ohci_platform_ids[] = { > { .compatible = "generic-ohci", }, > { } > }; > > I think you should just use that string on your platform. Excellent! I will drop this patch and use "generic-ohci" instead. Thanks for pointing this out. - Alistair > Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html