Hi Mauro, >-----Original Message----- >From: Mauro Carvalho Chehab [mailto:mchehab+samsung@xxxxxxxxxx] >Sent: Thursday, May 10, 2018 3:04 AM >To: Yeh, Andy <andy.yeh@xxxxxxxxx> >Cc: linux-media@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; tfiga@xxxxxxxxxxxx; jacopo@xxxxxxxxxx; Chiang, AlanX <alanx.chiang@xxxxxxxxx> >Subject: Re: [RESEND PATCH v9 2/2] media: dw9807: Add dw9807 vcm driver > >This adds a new warning. > >Thanks, >Mauro > > drivers/media/i2c/dw9807.c: In function 'dw9807_set_dac': > drivers/media/i2c/dw9807.c:81:16: warning: unused variable 'retry' [-Wunused-variable] > int val, ret, retry = 0; > ^ > >Please either fix or fold the following patch. > I noticed you just submitted a patch to the list to address the warning. Thanks. https://patchwork.linuxtv.org/patch/49575/ Just in the meantime, I uploaded the same one before noticing your patch. I would like to obsolete mine, so let me know if you agree too. Thanks. https://patchwork.linuxtv.org/patch/49574/ Regards, Andy >diff --git a/drivers/media/i2c/dw9807.c b/drivers/media/i2c/dw9807.c index 28ede2b47acf..6ebb98717fb1 100644 >--- a/drivers/media/i2c/dw9807.c >+++ b/drivers/media/i2c/dw9807.c >@@ -78,7 +78,7 @@ static int dw9807_set_dac(struct i2c_client *client, u16 data) > const char tx_data[3] = { > DW9807_MSB_ADDR, ((data >> 8) & 0x03), (data & 0xff) > }; >- int val, ret, retry = 0; >+ int val, ret; > > /* > * According to the datasheet, need to check the bus status before we -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
