On 05/12/2018 11:33 AM, Jonathan Cameron wrote: > On Mon, 7 May 2018 15:51:51 -0500 > Rob Herring <robh@xxxxxxxxxx> wrote: > >> On Wed, May 02, 2018 at 03:05:23PM +0200, Fabrice Gasnier wrote: >>> Add support for DFSDM (Digital Filter For Sigma Delta Modulators) >>> to STM32MP1. This variant is close to STM32H7 DFSDM, it implements >>> 6 filter instances. Registers map is also increased. >>> >>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx> >>> --- >>> .../bindings/iio/adc/st,stm32-dfsdm-adc.txt | 7 +++++-- >>> drivers/iio/adc/stm32-dfsdm-core.c | 21 +++++++++++++++++++++ >>> 2 files changed, 26 insertions(+), 2 deletions(-) >> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Applied. Whilst doing this I note that I'm getting a few sparse > warnings for this driver that would be nice to clean up... > > CHECK drivers/iio/adc/stm32-dfsdm-adc.c > drivers/iio/adc/stm32-dfsdm-adc.c:503:21: warning: expression using sizeof(void) > drivers/iio/adc/stm32-dfsdm-adc.c:503:21: warning: expression using sizeof(void) > > Which is mystifying at first glance... Something deep and dirty in the min macro > but I can't see what.. Hi Jonathan, I just sent a patch to clean bellow warning. But this is more obscure regarding min macro... Many thanks, Fabrice > > drivers/iio/adc/stm32-dfsdm-adc.c:680:5: warning: symbol 'stm32_dfsdm_get_buff_cb' was not declared. Should it be static? > drivers/iio/adc/stm32-dfsdm-adc.c:703:5: warning: symbol 'stm32_dfsdm_release_buff_cb' was not declared. Should it be static? > > Are rather more obvious > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
