On 05/14/2018 03:16 PM, Pavel Machek wrote: > On Mon 2018-05-14 15:13:34, Dan Murphy wrote: >> Pavel >> >> On 05/14/2018 03:05 PM, Pavel Machek wrote: >>> Hi! >>> >>>>> OK. >>>> >>>> OK I looked at the max776973 driver and well if the flash-max-microamp and >>>> flash-max-timeout-us nodes are missing it sets a default value for each if the >>>> node is not present. >>>> >>>> So should we remove this code from the Max77693 driver too and fail probe as being asked >>>> in this driver? >>> >>> Well, modifying driver without access to the hardware is tricky >>> :-(. If it does something stupid (like using other than minimum values >>> for the flash-max-microamp/flash-max-timeout-us), it needs to be >>> fixed. >> >> Well we should be able to test the probe/parse dt node and reject the probe if the node is not >> present. That can be done without HW the setup is done pretty early in the probe without even attempting to communicate >> with the hardware. >> > > Well, yes, you can do that. > > But if someone is actively using board with DT w/o flash-max-microamp, > you'll make them unhappy. > I grepped the dt directories and I did not find any upstream dt files configuring the max77693 with a flash led source. Unless Jacek can point out an upstream file I may have over looked. Unhappiness will come from not upstreaming your code ;) Dan > Best regards, > Pavel > -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
