On 14/05/18 11:22, Erin Lo wrote: > From: Ben Ho <Ben.Ho@xxxxxxxxxxxx> > > Add basic chip support for Mediatek 8183 > > Signed-off-by: Ben Ho <Ben.Ho@xxxxxxxxxxxx> > Signed-off-by: Erin Lo <erin.lo@xxxxxxxxxxxx> > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 31 +++++ > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 178 ++++++++++++++++++++++++++++ > 3 files changed, 210 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi > [...] > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > new file mode 100644 > index 0000000..8564a26 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi [...] > + gic: interrupt-controller@0c000000 { > + compatible = "arm,gic-v3"; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + reg = <0 0x0c000000 0 0x40000>, // CID > + <0 0x0c100000 0 0x200000>; // CIR You're missing the GICV and GICH regions that are present on both A53 and A73 at an offset from PERIPHBASE. > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; > + }; Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html