On 14.05.2018 07:10, Oleksij Rempel wrote: > > > On 14.05.2018 06:33, Oleksij Rempel wrote: >> >> >> On 12.05.2018 13:13, Rafael J. Wysocki wrote: >>> On Friday, May 4, 2018 8:50:52 PM CEST Oleksij Rempel wrote: >>>> Hallo Andrew, >>>> I need your ACK or NACK for this patch. >>>> >>>> This function is used to configure external PMIC to interpret >>>> signal which will be triggered by pm_power_off as power off. >>>> Since same signal can be used for stand by, I linked PMIC configuration >>>> with pm_power_off_prepare to avoid possible conflicts. >>>> >>>> On Mon, Mar 05, 2018 at 11:25:20AM +0100, Oleksij Rempel wrote: >>>>> Export pm_power_off_prepare. It is needed to implement power off on >>>>> Freescale/NXP iMX6 based boards with external power management >>>>> integrated circuit (PMIC). >>>>> >>>>> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> >>>>> --- >>>>> kernel/reboot.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/kernel/reboot.c b/kernel/reboot.c >>>>> index e4ced883d8de..350be6baa60d 100644 >>>>> --- a/kernel/reboot.c >>>>> +++ b/kernel/reboot.c >>>>> @@ -49,6 +49,7 @@ int reboot_force; >>>>> */ >>>>> >>>>> void (*pm_power_off_prepare)(void); >>>>> +EXPORT_SYMBOL(pm_power_off_prepare); >>> >>> Why not EXPORT_SYMBOL_GPL() ? >> >> No special reason. Fixed. >> Any other comments? >> > > Or with other words, will it be enough to get your Signed-of-by for this > patch? Hi again, i was punished by my colleagues and actually by Russel for asking "Signed-of-by". So, I correct my self, is it enough for a Reviewed-by?
Attachment:
signature.asc
Description: OpenPGP digital signature
