On 05/13/2018 02:24 PM, Krzysztof Kozlowski wrote: > On Fri, May 11, 2018 at 10:09:47AM +0200, Sylwester Nawrocki wrote: >> Use dedicated Odroid audio subsystem DT bindings instead of the simple-card. >> This adds support for audio on the HDMI interface. > How about changing the subject to "Add suppor for audio over HDMI for > Odroid X/X2/U3"? Sure, I don't mind. >> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts >> index bdcd4523cc1c..7a94a423097d 100644 >> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts >> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts >> @@ -113,11 +113,12 @@ >> }; >> >> &sound { >> - simple-audio-card,name = "Odroid-U3"; >> - simple-audio-card,widgets = >> + compatible = "hardkernel,odroid-xu4-audio"; > The compatible is the same for all users using DTSI so it could be moved > to the exynos4412-odroid-common.dtsi itself. Corrected. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html