Hi Elaine, Am Freitag, 11. Mai 2018, 05:30:49 CEST schrieb Elaine Zhang: please provide a patch description. This seems to affect rk3328 alone right now, but seems that rk3328 could only ever turn off power-domains but never turn them on again, right? Authorship comment from my previous comment applies here as well. And please add a Fixes: 9bb17ce8edb3 ("soc: rockchip: power-domain: Support domain control in hiword-registers") Cc: stable@xxxxxxxxxxxxxxx to the patch description. Thanks Heiko > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx> > --- > drivers/soc/rockchip/pm_domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c > index ebd7c41898c0..01d4ba26a054 100644 > --- a/drivers/soc/rockchip/pm_domains.c > +++ b/drivers/soc/rockchip/pm_domains.c > @@ -264,7 +264,7 @@ static void rockchip_do_pmu_set_power_domain(struct rockchip_pm_domain *pd, > return; > else if (pd->info->pwr_w_mask) > regmap_write(pmu->regmap, pmu->info->pwr_offset, > - on ? pd->info->pwr_mask : > + on ? pd->info->pwr_w_mask : > (pd->info->pwr_mask | pd->info->pwr_w_mask)); > else > regmap_update_bits(pmu->regmap, pmu->info->pwr_offset, > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html