Hi Elaine, Am Freitag, 11. Mai 2018, 05:34:32 CEST schrieb Elaine Zhang: > According to a description from TRM, add all the power domains. > > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx> that's a bit ambigous, having the Signed-offs like above. Either you are the author+sender of the patch, then Finley's Signed-off should go away ... or Finley is the author and you are the sender, then the author of the patch should be set correctly (--author option for git) and the Signed-offs should switch places (= Finley first, then yours). Please fix. This seems to be true for most patches in this series. > --- > include/dt-bindings/power/px30-power.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 include/dt-bindings/power/px30-power.h > > diff --git a/include/dt-bindings/power/px30-power.h b/include/dt-bindings/power/px30-power.h > new file mode 100644 > index 000000000000..4ed482e80950 > --- /dev/null > +++ b/include/dt-bindings/power/px30-power.h Here I have a naming question. When looking at the vendor kernel it looks like the px30 is largely related to the rk3326. (rk3326.dtsi includeing the px30.dtsi) What is the reason for basing the naming on the px30 this time? And could we possibly keep to rkXXXX names for the basic things in the kernel, thus keeping the pxXX as second name, like with the other px-variants before? Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
