Hi Pavel, On 9 May 2018 at 22:25, Pavel Machek <pavel@xxxxxx> wrote: > Hi! > >> This patch adds the binding documentation for Spreadtrum SC27xx series >> breathing light controller, which supports 3 outputs: red LED, green >> LED and blue LED. >> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> >> --- >> Changes since v1: >> - Change the compatible string to be one explicit SoC name. >> - Change the child node name. >> - Change to be upper case for the first character. >> --- >> .../devicetree/bindings/leds/leds-sc27xx-bltc.txt | 41 ++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt b/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt >> new file mode 100644 >> index 0000000..b3de7fc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt >> @@ -0,0 +1,41 @@ >> +LEDs connected to Spreadtrum SC27XX PMIC breathing light controller >> + >> +The SC27xx breathing light controller supports to 3 outputs: >> +red LED, green LED and blue LED. Each LED can work at normal >> +PWM mode or breath light mode. > >> +Required properties: >> +- compatible: Should be "sprd,sc2731-bltc". > > If this is for 2731, I'd say so in the title and the filename...? I agree with Jacek's comments. We will add other PMICs belonging to sc27xx series in future. > >> +- #address-cells: Must be 1. >> +- #size-cells: Must be 0. >> +- reg: Specify controller address. > > the controller... Will fix. > >> +Required child properties: >> +- reg: Number of LED line (could be from 0 to 2). > > Uff. "Port this LED is connected to"? Will fix. > > With that fixed... > > Acked-by: Pavel Machek <pavel@xxxxxx> Thanks for your comments. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
