On Fri, Feb 21, 2014 at 03:41:03PM +0000, Felipe Balbi wrote:
> Hi,
>
> On Fri, Feb 21, 2014 at 12:04:54PM +0000, Mark Rutland wrote:
> > > > +Example:
> > > > + axi-usb2-device@42e00000 {
> > > > + compatible = "xlnx,axi-usb2-device-4.00.a";
> > > > + interrupt-parent = <0x1>;
> > > > + interrupts = <0x0 0x39 0x1>;
> > > > + reg = <0x42e00000 0x10000>;
> > > > + xlnx,include-dma = <0x1>;
> > > > + };
> > > > +
> > >
> > > you need to Cc devicetree@xxxxxxxxxxxxxxx for this.
> >
> > Cheers Filipe; thanks for adding us to Cc :)
>
> sure, but it's "Felipe" ;-)
Whoops; sorry Felipe :)
>
> > > > + /* Map the registers */
> > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > > + udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start,
> > > > + resource_size(res));
> > >
> > > use devm_ioremap_resource() instead.
> >
> > Also, res might be NULL. You should check that before dereferencing it.
>
> not needed when using devm_ioremap_resource(), see the implementation.
Ah, good to know.
Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
