All On 05/09/2018 03:26 AM, Julia Lawall wrote: > From: Fengguang Wu <fengguang.wu@xxxxxxxxx> > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver") > CC: Dan Murphy <dmurphy@xxxxxx> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx> > --- > > url: > https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > for-next > :::::: branch date: 5 hours ago > :::::: commit date: 5 hours ago > > I also received the following comment, but no other details. It would be > good to check what is going on on the mentioned lines. > >>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311 > > leds-lm3601x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/leds/leds-lm3601x.c > +++ b/drivers/leds/leds-lm3601x.c > @@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led > > ret = -EINVAL; > goto out; > - }; > + } > I will fix this in v3 of the patch submission. Dan > if (led->strobe_timeout != current_timeout) > ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG, > -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html