Re: [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 09, 2018 at 09:19:13AM +0530, Jassi Brar wrote:
> On Wed, Apr 4, 2018 at 8:44 AM, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
> > From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> >
> > The current defconfig is inconsistent as it selects the mailbox and
> > the clock for the hi6220 and the hi3660 without having their Kconfigs
> > making sure the dependencies are correct. It ends up when selecting
> > different versions for the kernel (for example when git bisecting)
> > those options disappear and they don't get back, leading to unexpected
> > behaviors. In our case, the cpufreq driver does no longer work because
> > the clock fails to initialize due to the clock stub and the mailbox
> > missing.
> >
> > In order to have the dependencies correctly set when defaulting, let's
> > do the same as commit 3a49afb84ca074e ("clk: enable hi655x common clk
> > automatically") where we select automatically the driver when the
> > parent driver is selected. With sensible defaults in place, we can leave
> > other choices for EXPERT.
> >
> Acked-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>

Thanks Jassi & Stephen.

Wei, could you pick this patch?

Thanks,
Leo Yan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux