Re: [PATCHv2 3/3] arm64: dts: stratix10: add sdram ecc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Boris,

On Mon, May 7, 2018 at 3:50 PM, Dinh Nguyen <dinh.linux@xxxxxxxxx> wrote:
> On Mon, May 7, 2018 at 11:59 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
>> On Fri, Apr 27, 2018 at 01:37:18PM -0500, thor.thayer@xxxxxxxxxxxxxxx wrote:
>>> From: Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>
>>>
>>> Add the Stratix10 ECC Manager and SDRAM EDAC nodes to the
>>> device tree.
>>>
>>> Signed-off-by: Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>
>>> ---
>>> v2  Remove unused SysMan syscon
>>>     Remove unused SDRAM ECC register defines
>>>     Remove unused address, size and range from device tree.
>>> ---
>>>  arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> index c89d0c307f8d..688391f3bf78 100644
>>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> @@ -387,5 +387,17 @@
>>>                       resets = <&rst WATCHDOG3_RESET>;
>>>                       status = "disabled";
>>>               };
>>> +
>>> +             eccmgr {
>>> +                     compatible = "altr,socfpga-s10-ecc-manager";
>>> +                     interrupts = <0 15 4>, <0 95 4>;
>>> +                     interrupt-controller;
>>> +                     #interrupt-cells = <2>;
>>> +
>>> +                     sdramedac {
>>> +                             compatible = "altr,sdram-edac-s10";
>>> +                             interrupts = <16 4>, <48 4>;
>>> +                     };
>>> +             };
>>>       };
>>>  };
>>> --
>>> 2.7.4
>>>
>>> --
>>
>> Hey Rob,
>>
>> ACK here too?
>>
>> Also, this one:
>>
>> https://lkml.kernel.org/r/1525203036-21774-1-git-send-email-thor.thayer@xxxxxxxxxxxxxxx
>>
>> ?
>>
>
> Just in case you need mine, since the edits here match what was in the
> in the bindings doc.
>
> Acked-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
>

Do you mind if I take this patch through arm-soc? I have a pull
request to arm-soc that is pending.

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/573133.html

In that pull request, there is a patch:

https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/commit/?h=socfpga_for_next_v4.18_dts_v1&id=d93101abe41e9596555a0f7f6f775e543b71c441

This patch has some major changes to the socfpga_stratix10.dtsi file
that will conflict with this patch.

If it's okay with you.

Thanks,
Dinh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux