On Fri, Feb 21, 2014 at 09:40:29AM +0000, Peter Chen wrote: > > > > > > > Required properties: > > > -- compatible: Should be "fsl,imx23-usbphy" > > > +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q- > > usbphy" > > > + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl > > > > Minor nit, but could we restructure this as something like the following, > > with each string on a new line: > > > > - compatible: should contain: > > * "fsl,imx23-usbphy" for imx23 and imx28 > > * "fsl,imx6q-usbphy" for imx6dq and imx6dl > > * "fsl,imx6sl-usbphy" for imx6sl > > > > It makes it a bit easier to read. > > Thanks, will change like above. > > > > > I see the existing "fsl,imx23-usbphy" is used as a fallback for > > "fsl,imx28-usbphy", "fsl,imx6q-usbphy", and "fsl,imx6sl-usbphy" in > > existing DTs. > > > > Is this expected going forward? It might be worth mentioning. > > > > These SoCs used the same FSL imx PHY, but different versions. > imx23/imx28 are the first version, more improvements are at > later SoCs (like imx6x) version. Keep "fsl,imx23-usbphy" at > imx6 dts will be user know it is from imx23's. If you think > it does not need, I can delete "fsl,imx23-usbphy" from imx6 dts. I'm not arguing to remove it, I'm suggesting it might be worth mentioning that it's not mutually exclusive, and can be a fallback for the other strings. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
