On Fri, Feb 21, 2014 at 09:21:27AM +0000, Mark Rutland wrote:
> On Thu, Feb 20, 2014 at 05:14:39AM +0000, Peter Chen wrote:
> > When we need the PHY can be waken up by external signals,
> > we can call this API. Besides, we call mxs_phy_disconnect_line
> > at this API to close the connection between USB PHY and
> > controller, after that, the line state from controller is SE0.
> > Once the PHY is out of power, without calling mxs_phy_disconnect_line,
> > there are unknown wakeups due to dp/dm floating at device mode.
> >
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> > drivers/usb/phy/phy-mxs-usb.c | 116 +++++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 116 insertions(+), 0 deletions(-)
>
> [...]
>
> > +static void mxs_phy_disconnect_line(struct mxs_phy *mxs_phy, bool on)
> > +{
> > + bool vbus_is_on = false;
> > +
> > + /* If the SoCs don't need to disconnect line without vbus, quit */
> > + if (!(mxs_phy->data->flags & MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS))
> > + return;
> > +
> > + /* If the SoCs don't have anatop, quit */
> > + if (!mxs_phy->regmap_anatop)
> > + return;
>
> So it looks like fsl,anatop is truly optional.
>
Like I said at 04/15, if the user wants full features and less bugs,
it is required.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
