Hi Thomas, On Mon, 30 Apr 2018 15:49:13 +0200, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote: > Hello, > > In the title, I think "user data" is not really appropriate. "private > date" or "device private data" maybe ? Sure, I will change to "fix wrong private data retrieval". > > On Sat, 21 Apr 2018 15:55:24 +0200, Miquel Raynal wrote: > > The irq_domain structure has an host_data pointer that just stores user > > data. It is meant to not be touched by the IRQ core. However, when it > > comes to MSI, the MSI layer adds its own private data there with a > > structure that also has a host_data pointer. > > > > Because this IRQ domain is an MSI domain, to access user data we should > > do a d->host_data->host_data, also wrapped as > > 'platform_msi_get_host_data()'. > > > > This bug was lying there silently because the 'icu' structure retrieved > > this way was just called by dev_err(), only producing a > > '(NULL device *):' output on the console. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > Otherwise: > > Reviewed-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> Thanks, Miquèl -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
