On Fri, Apr 27, 2018 at 11:20:01PM +0000, Brandon Maier wrote:
> On Fri, Apr 27, 2018 at 4:13 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> ...
> > > + gem0: ethernet@e000b000 {
> > > + compatible = "cdns,zynq-gem", "cdns,gem";
> > > + phy-handle = <&phy>;
>
> > The phy here and...
> ...
> > > + gmiitorgmii: gmiitorgmii@8 {
> > > + compatible = "xlnx,gmii-to-rgmii-1.0";
> > > + reg = <8>;
> > > + phy-handle = <&phy>;
>
> > ...here doesn't look right.
>
>
> I don't see what you're referring to, they appear to match the
> phy/phy-handle formats in Documentation/devicetree/bindings/net/phy.txt and
> ethernet.txt. It's a bit odd that the label is just "phy", when most phy
> labels are "phy0" etc., is that what should be changed?
You don't need both properties. If the ethernet driver needs the phy,
then it can decend into the child nodes to find it.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
