On Monday, April 30, 2018 1:30:36 PM CEST Lee Jones wrote:
> On Fri, 27 Apr 2018, Paweł Chmiel wrote:
>
> > This patch adds devicetree bindings documentation for
> > battery charging controller as the subnode of MAX8998 PMIC.
> > It's based on current behavior of driver.
> >
> > Fixes: ee999fb3f17f ("mfd: max8998: Add support for Device Tree")
>
> Why is this here? This patch doesn't look like a fix to me.
Hi
I though that if previous patch, which is adding missing device tree parsing into charger driver,
has fixes tag, this patch (which is documenting it), should also contain that tag.
If it shouldn't be here, i can fix this in v2.
Thanks for feedback (this is my second patchset for Linux Kernel)
>
> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/mfd/max8998.txt | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/max8998.txt b/Documentation/devicetree/bindings/mfd/max8998.txt
> > index 23a3650ff2a2..f95610afb57f 100644
> > --- a/Documentation/devicetree/bindings/mfd/max8998.txt
> > +++ b/Documentation/devicetree/bindings/mfd/max8998.txt
> > @@ -50,6 +50,21 @@ Additional properties required if max8998,pmic-buck2-dvs-gpio is defined:
> > - max8998,pmic-buck2-dvs-voltage: An array of 2 voltage values in microvolts
> > for buck2 regulator that can be selected using dvs gpio.
> >
> > +Charger: Configuration for battery charging controller should be added
> > +inside a child node named 'charger'.
> > + Required properties:
> > + - max8998,charge-eoc: Setup "End of Charge". If value equals 0,
> > + remain value set from bootloader or default value will be used.
> > + Valid values: 0, 10 - 45
> > +
> > + - max8998,charge-restart: Setup "Charge Restart Level". If value equals 0,
> > + remain value set from bootloader or default value will be used.
> > + Valid values: -1, 0, 100, 150, 200
> > +
> > + - max8998,charge-timeout: Setup "Charge Full Timeout". If value equals 0,
> > + remain value set from bootloader or default value will be used.
> > + Valid values: -1, 0, 5, 6, 7
> > +
> > Regulators: All the regulators of MAX8998 to be instantiated shall be
> > listed in a child node named 'regulators'. Each regulator is represented
> > by a child node of the 'regulators' node.
> > @@ -99,6 +114,13 @@ Example:
> > max8998,pmic-buck2-dvs-gpio = <&gpx0 0 3 0 0>; /* SET3 */
> > max8998,pmic-buck2-dvs-voltage = <1350000>, <1300000>;
> >
> > + /* Charger configuration */
> > + charger {
> > + max8998,charge-eoc = <0>;
> > + max8998,charge-restart = <(-1)>;
> > + max8998,charge-timeout = <7>;
> > + };
> > +
> > /* Regulators to instantiate */
> > regulators {
> > ldo2_reg: LDO2 {
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
