On Mon, 30 Apr 2018 11:13:45 +0200
Hi Linus,
> On Sun, Apr 22, 2018 at 11:31 PM, Lukasz Majewski <lukma@xxxxxxx>
> wrote:
>
> > From: Stanislav Meduna <stanislav.meduna@xxxxxxxxxxxxxx>
> >
> > On a TQMa53 module the mmc_sleep leaves the eMMC card in a state
> > that the imx53 rom boot code is unable to probe, resulting in
> > reboot hanging. Add a device tree property to disable sleeping
> > on suspend.
> >
> > For TQMa53 modules the exact commit to cause hang after reboot
> > (v3.10 -> v3.11):
> > commit 486fdbbc1483 ("mmc: core: Add shutdown callback for (e)MMC
> > bus_ops")
> >
> > [The exact discussion can be found here:
> > https://patchwork.kernel.org/patch/8881401/
> > "i.MX53 restart via watchdog does not work"
> >
> > Signed-off-by: Stanislav Meduna <stanislav.meduna@xxxxxxxxxxxxxx>
> > Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> (...)
>
> > Optional properties:
> > -broken-hpi : Use this to indicate that the mmc-card has a broken
> > hpi implementation, and that hpi should not be used
> > +-no-sleep-on-suspend : Do not put the card to sleep when
> > suspending.
> > + There are boards with bootloaders that are unable
> > + to probe such card when rebooting.
>
> As far as I understand this problem is not coming from the host
> controller itself,
> so it should not be tagged on to the host controller either. Rather
> the problem is how the specific system has integrated the host
> controller, the problem is in the fixture of this specific machine,
> as you say, in the i.MX53 ROM.
>
> In that case, I would say use this:
>
> if (of_machine_is_compatible("fsl,imx53")) {
> ..activate quirk...
> }
I see. Thanks for pointing this.
>
> Yours,
> Linus Walleij
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@xxxxxxx
Attachment:
pgp9Pw9al0r6n.pgp
Description: OpenPGP digital signature
