On 04/17/2018 12:30 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > Checkpatch recommends to use octal perms instead of S_IRUGO. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> Looks like you missed by Acked-by from v3, so adding it back Acked-by: Suman Anna <s-anna@xxxxxx> regards Suman > --- > drivers/remoteproc/da8xx_remoteproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c > index f134192922e0..b668e32996e2 100644 > --- a/drivers/remoteproc/da8xx_remoteproc.c > +++ b/drivers/remoteproc/da8xx_remoteproc.c > @@ -25,7 +25,7 @@ > #include "remoteproc_internal.h" > > static char *da8xx_fw_name; > -module_param(da8xx_fw_name, charp, S_IRUGO); > +module_param(da8xx_fw_name, charp, 0444); > MODULE_PARM_DESC(da8xx_fw_name, > "Name of DSP firmware file in /lib/firmware (if not specified defaults to 'rproc-dsp-fw')"); > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
