Hi Tony, On Wednesday 25 April 2018 07:05 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I <kishon@xxxxxx> [180425 12:57]: >> --- a/arch/arm/boot/dts/dra74x-mmc-iodelay.dtsi >> +++ b/arch/arm/boot/dts/dra74x-mmc-iodelay.dtsi >> @@ -49,6 +49,17 @@ >> >; >> }; >> >> + mmc1_pins_default_no_clk_pu: mmc1_pins_default_no_clk_pu { >> + pinctrl-single,pins = < >> + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mmc1_clk.clk */ >> + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */ >> + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */ >> + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */ >> + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */ >> + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */ >> + >; >> + }; >> + >> mmc1_pins_sdr12: mmc1_pins_sdr12 { >> pinctrl-single,pins = < >> DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_clk.clk */ >> -- > > If this data is the same for all of them, why don't you add something > like dra7-iodelay.dtsi that can be included as needed? okay, I'll add dra7-mmc-iodelay.dtsi and send a new revision. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html