Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Lew/Add-chrdev-and-name-query-support-for-GLINK/20180427-023202 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/rpmsg/qcom_glink_native.c:624:16: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [usertype] id @@ got short [unsigned] [usertype] id @@ drivers/rpmsg/qcom_glink_native.c:624:16: expected unsigned short [unsigned] [usertype] id drivers/rpmsg/qcom_glink_native.c:624:16: got restricted __le16 [usertype] <noident> drivers/rpmsg/qcom_glink_native.c:625:18: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [usertype] lcid @@ got short [unsigned] [usertype] lcid @@ drivers/rpmsg/qcom_glink_native.c:625:18: expected unsigned short [unsigned] [usertype] lcid drivers/rpmsg/qcom_glink_native.c:625:18: got restricted __le16 [usertype] <noident> drivers/rpmsg/qcom_glink_native.c:626:19: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] count @@ got ed int [unsigned] [usertype] count @@ drivers/rpmsg/qcom_glink_native.c:626:19: expected unsigned int [unsigned] [usertype] count drivers/rpmsg/qcom_glink_native.c:626:19: got restricted __le32 [usertype] <noident> drivers/rpmsg/qcom_glink_native.c:627:18: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] size @@ got ed int [unsigned] [usertype] size @@ drivers/rpmsg/qcom_glink_native.c:627:18: expected unsigned int [unsigned] [usertype] size drivers/rpmsg/qcom_glink_native.c:627:18: got restricted __le32 [usertype] <noident> drivers/rpmsg/qcom_glink_native.c:628:18: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] liid @@ got ed int [unsigned] [usertype] liid @@ drivers/rpmsg/qcom_glink_native.c:628:18: expected unsigned int [unsigned] [usertype] liid drivers/rpmsg/qcom_glink_native.c:628:18: got restricted __le32 [usertype] <noident> >> drivers/rpmsg/qcom_glink_native.c:1569:1: sparse: incorrect type in initializer (different modifiers) @@ expected struct attribute **attrs @@ got structstruct attribute **attrs @@ drivers/rpmsg/qcom_glink_native.c:1569:1: expected struct attribute **attrs drivers/rpmsg/qcom_glink_native.c:1569:1: got struct attribute const **<noident> In file included from include/linux/kobject.h:20:0, from include/linux/irqdesc.h:6, from include/linux/irq.h:517, from arch/x86/include/asm/hardirq.h:6, from include/linux/hardirq.h:9, from include/linux/interrupt.h:11, from drivers/rpmsg/qcom_glink_native.c:15: drivers/rpmsg/qcom_glink_native.c:1569:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] ATTRIBUTE_GROUPS(qcom_glink); ^ include/linux/sysfs.h:154:11: note: in definition of macro 'ATTRIBUTE_GROUPS' .attrs = _name##_attrs, 31- ^~~~~ drivers/rpmsg/qcom_glink_native.c:1569:18: note: (near initialization for 'qcom_glink_group.attrs') ATTRIBUTE_GROUPS(qcom_glink); ^ include/linux/sysfs.h:154:11: note: in definition of macro 'ATTRIBUTE_GROUPS' .attrs = _name##_attrs, 37- ^~~~~ cc1: some warnings being treated as errors vim +1569 drivers/rpmsg/qcom_glink_native.c 1564 1565 static const struct attribute *qcom_glink_attrs[] = { 1566 &dev_attr_rpmsg_name.attr, 1567 NULL 1568 }; > 1569 ATTRIBUTE_GROUPS(qcom_glink); 1570 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
