From: Greg KH > Sent: 23 April 2018 13:03 > On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.gong@xxxxxxxxxxxxxxx wrote: > > +config INTEL_SERVICE > > Naming is hard, but this is a _very_ generic name, don't you agree? > > > + tristate "Intel Service Layer" > > As is this. Can you make this a bit more specific to what hardware is > being controlled here? > > > +++ b/drivers/misc/intel-service.c > > Same for the file name, why not stratix10.c? > > or intel_svc.c? That makes it a _bit_ more generic. Well, not really, > but it does hide the "genericness" a bit more, right? It'll all be even worse if (when) Intel decide to sell Altera to someone else. David -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html