On Fri, Apr 20, 2018 at 12:04:44PM +0200, Jean-Jacques Hiblot wrote:
> + - mute-gpio: GPIO used to mute all the outputs
Same thing with the plural here.
> + if (tas6424->mute_gpio) {
> + gpiod_set_value_cansleep(tas6424->mute_gpio, mute ? 1 : 0);
> + return 0;
> + }
Just use mute directly, the ternery operator is doing nothing for
legibility here and C does the integer to boolean thing for you.
> + if (tas6424->mute_gpio) {
> + gpiod_set_value_cansleep(tas6424->mute_gpio, 0);
> + /*
> + * channels are muted via the mute pin, don't also. Don't also
> + * mute them via the registers so that subsequent register
> + * access is not necessary to un-mute the channels
Extra "don't also" in there.
Attachment:
signature.asc
Description: PGP signature
