Hi, On 23.4.2018 15:16, Matt Redfearn wrote: > > > On 23/04/18 10:27, Michal Simek wrote: >> There is no reason to initialize uartclk to BASE_BAUD * 16 for DT based >> systems. >> >> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> >> --- >> >> It looks like from history that portclk = BASE_BAUD * 16 was setup to >> get on calculation on x86 (divisor = 1) but it shouldn't be needed on >> DT based >> system. That's why I think that there is no DT based system which really >> requires this line. > > Hi Michal, > > This is fine for the MIPS generic platform (tested on Boston board) > which was broken by some earlycon changes a few versions ago. Also > tested on a MIPS pistachio board. As long as the bootloader has > configured the uart divisor, earlycon should work as long as my patch > "serial: 8250_early: Only set divisor if valid clk & baud" is applied to > avoid a bad divisor getting calculated. I have sent one patch to fix your patch because you don't need to check device->baud twice. [PATCH] serial: 8250_early: Setup divider when uartclk is passed > Tested-by: Matt Redfearn <matt.redfearn@xxxxxxxx> Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
