Hi Rob, > Eric Anholt <eric@xxxxxxxxxx> hat am 17. April 2018 um 18:02 geschrieben: > > > Stefan Wahren <stefan.wahren@xxxxxxxx> writes: > > > Hi Rob, > > > > Am 16.04.2018 um 22:43 schrieb Rob Herring: > >> On Fri, Apr 13, 2018 at 07:27:53PM +0200, Stefan Wahren wrote: > >>> The Raspberry Pi 3 B+ has the following major differences compared > >>> to the model 3 B: > >>> * Microchip LAN7515 (Gigabit Ethernet) > >>> * Cypress CYW43455 (802.11n/ac and BT 4.2) > >>> > >>> We need to add the USB LAN chip so the bootloader can add the MAC address. > >>> This is necessary because there ain't a EEPROM or a valid OTP. > >>> > >>> Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx> > >>> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > >>> --- > >>> arch/arm/boot/dts/Makefile | 1 + > >>> arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 108 +++++++++++++++++++++++++++++ > >>> arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi | 27 ++++++++ > >>> 3 files changed, 136 insertions(+) > >>> create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts > >>> create mode 100644 arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi > >>> > >>> ... > >>> diff --git a/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi b/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi > >>> new file mode 100644 > >>> index 0000000..169203c > >>> --- /dev/null > >>> +++ b/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi > >> Why the separate file? This can be shared? > > > > this comes from the assumption the RPi 3 B+ won't be the only RPi board > > with a LAN7515. Should i fold it in the dts file as long as we don't > > have a second board? > > I think it's great as is -- our other network chips are hooked up this > way and it makes 3b+ match all the others. Also, while I have no > specific knowledge, it seems likely that this would get reused. sorry for my impatience, but what's your opinion? Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html