On Wed, Feb 19, 2014 at 06:18:09PM +0100, Hans de Goede wrote: > Most of the resources are already devres managed (I use devm functions > to get them), the problem is not in freeing our reference to the resources, > the problem is that we've sequences like this: > > devm_get_foo > enable_foo > disable_foo > (automatic release foo) > > Where enable / disable can be done repeatedly (ie each suspend / resume). > > From your review comments, I take it that you want the final disable_foo > on driver release to happen automatically. > > My preference for this would be to extend the devres tracking already present > in the relevant subsystems to keep track of the enable count done through a > specific reference, to allow automatic disable (if needed) on release. > > But thinking more about this, I think that doing this automatically is a bad > idea, because then we fixate the shutdown sequence to a certain order (the > order in which we did the _get_foo for the resources) and the correct order may > be device specific. > > So TL;DR: Yes to making things so that ahci_platform_put_resources gets done > automatically, no to automating the disable calls. > > If I don't hear back from you, then I'll respin the patch-set assuming that > you agree to the above. Yeah, sounds good enough to me. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
