On 19/04/18 18:26, Rob Herring wrote:
On Thu, Apr 19, 2018 at 1:36 AM, Tero Kristo <t-kristo@xxxxxx> wrote:
On 19/04/18 01:43, Rob Herring wrote:
On Wed, Apr 18, 2018 at 9:20 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
Hi Tero,
On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@xxxxxx> wrote:
Symbols in the DTB files are needed so that overlays can be applied
properly. Add support for building TI SoC specific .dtb files, the
source is fetched from parent directory.
Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
Thanks for your patch!
---
arch/arm/boot/dts/ti/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/ti/Makefile
b/arch/arm/boot/dts/ti/Makefile
index b26328b..7d2d411 100644
--- a/arch/arm/boot/dts/ti/Makefile
+++ b/arch/arm/boot/dts/ti/Makefile
@@ -1 +1,6 @@
+DTC_FLAGS += -@ -Wno-reg_format -Wno-avoid_default_addr_size
Why the -W options?
+
+$(obj)/%.dtb: $(src)/../%.dts FORCE
I guess you want a dependency on $(DTC), too?
I think that is handled globally already. I did a fix not to long ago.
Globally it is handled, but as you see this is a special rule under the TI
SoC specific makefile. This is building the .dts files under
arch/arm/boot/dts/* into arch/arm/boot/dts/ti/ containing the symbol info
(-@ flag for DTC.)
Ah, I see. That means we end up with 2 builds of the base dtbs, right?
Yes, thats intentional in this series.
We need to not do that. Either we need to be able to set per dtb flags
or set per directory flags and move the TI base dts files to /ti
directory.
Well, actually we kind of need two builds of the same file. One is for
the base beagle-x15 board, which doesn't need any overlays, and as such,
does not need the symbol info either. The other one needs symbol info,
as it is used with applying overlays. The application of overlays can't
be done without the symbol info.
If we force both builds to use symbols, then the resulting beagle-x15
DTB file is unnecessarily large (the size delta might be irrelevant in
practice, but it is there; ~40 kilobytes in this case, or +50% increase
in size.)
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
