Hi, On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote: > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx> > > > > Document device tree binding information as required by > > the Qualcomm USB controller. > > > > Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx> > > --- > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ > > Although you mentioned to Josh that this is intended for "non-standard" > Chipidea properties, I don't see any other than requiring that 'dr_mode' > must be "peripheral". It would seem that this should all be integrated > into a ci3xxx.txt. Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt. So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt? > > +CI13xxx (Chipidea) USB controllers > > + > > +Required properties: > > +- compatible: should contain "qcom,ci-hdrc" > > Is there nothing more specific you could put here? Maybe a hardware > revision, or something? > I am not aware of any version numbers here, sorry. > > +- reg: offset and length of the register set in the memory map > > +- interrupts: interrupt-specifier for the controller interrupt. > > +- usb-phy: phandle for the PHY device > > +- dr_mode: Sould be "peripheral" > > s/Sould/should/ Thanks, Ivan > > -Courtney -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
