Re: [PATCH 01/15] media: staging/imx: add support to media dev for no IPU systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,
Thanks for this and the other reviews.

On Thu 19 Apr 2018 at 12:06, Dan Carpenter wrote:
On Thu, Apr 19, 2018 at 11:17:58AM +0100, Rui Miguel Silva wrote:
Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have
internal subdevices besides the CSI.

Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx>
---
drivers/staging/media/imx/imx-media-dev.c | 16 +++++++++++-----
 .../staging/media/imx/imx-media-internal-sd.c    |  3 +++
 drivers/staging/media/imx/imx-media.h            |  3 +++
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-dev.c b/drivers/staging/media/imx/imx-media-dev.c
index f67ec8e27093..a8afe0ec4134 100644
--- a/drivers/staging/media/imx/imx-media-dev.c
+++ b/drivers/staging/media/imx/imx-media-dev.c
@@ -92,6 +92,9 @@ static int imx_media_get_ipu(struct imx_media_dev *imxmd,
 	struct ipu_soc *ipu;
 	int ipu_id;
+ if (imxmd->no_ipu_present)

It's sort of nicer if variables don't have a negative built in because otherwise you get confusing double negatives like "if (!no_ipu) {". It's not hard to invert the varible in this case, because the only thing
we need to change is imx_media_probe() to set:

+	imxmd->ipu_present = true;

Yeah, my code was like this till last minute, and I also dislike the double negatives... but since the logic that reset the variable would
only be done in a later patch I switched the logic.

But You are right I could just had the initialization here to true.
Will take this in account in v2.

---
Cheers,
	Rui

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux