On Tue, Apr 17, 2018 at 4:10 AM, Tero Kristo <t-kristo@xxxxxx> wrote: > The AM57xx-evm is an overlay on top of beagle-x15 board. This contains > a display extension macro, and a few extra peripherals. Two versions > of the evm are supported, the base evm and the latest rev A3 evm. A > common overlay file is used for both boards. > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > --- > arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ Why do this as an overlay? To what level is an AM57xx-evm functional using a beagle-x15 dtb? > arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ > arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ I think I'd structure this as just the A3 is an overlay. Applying it will override everything in am57xx-evm.dtso, so what's the point to making users of both board variations apply an overlay. Plus, you could have only known the differences in the board revisions after you had both boards. That wouldn't work if you developed this as new boards appear. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
