On Sun, Apr 15, 2018 at 7:55 AM, Craig Tatlor <ctatlor97@xxxxxxxxx> wrote: > On Fri, Apr 13, 2018 at 11:35:27AM -0500, Rob Herring wrote: >> On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote: >> > Add bindings for the Qualcomm Battery Monitoring system. >> > >> > Signed-off-by: Craig Tatlor <ctatlor97@xxxxxxxxx> >> > --- >> > .../bindings/power/supply/qcom_bms.txt | 93 +++++++++++++++++++ >> > 1 file changed, 93 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt >> > >> > diff --git a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt >> > new file mode 100644 >> > index 000000000000..6296399edc09 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt >> > @@ -0,0 +1,93 @@ >> > +Qualcomm Battery Measurement System >> > + >> > +The Qualcomm Battery Measurement System is found inside of Qualcomm PM8941 >> >> Is it Monitoring or Measurment? >> >> > +PMICs. It provides OCV and coulomb counter registers that allow the kernel >> > +to infer a capacity level. >> >> s/kernel/OS/ >> >> OCV? >> >> > + >> > +Required properties: >> > +- compatible: Should contain "qcom,pm8941-bms". >> > +- reg: Specifies the SPMI address and length of the >> > + controller's registers. >> > +- interrupts: OCV threshold interrupt. >> > +- io-channels: Should contain IIO channel specifier for the >> > + ADC channel that reports battery temperature. >> > +- io-channel-names: Should contain "temp". >> > +- qcom,fcc-temp-legend: An array containing the temperature, in degC, >> > + for each column of the FCC lookup table. >> >> What's FCC? >> >> > +- qcom,fcc-lut: An array of FCC values in mah, one entry for each >> > + temperature defined in in qcom,fcc-temp-legend. >> > +- qcom,ocv-temp-legend: An array containing the temperature, in degC, >> > + for each column of the OCV lookup table. >> > +- qcom,ocv-capacity-legend: An array containing the capacity for each >> > + row of the OCV lookup table. >> > +- qcom,ocv-lut: An array of OCV values in mV, one entry for each >> > + capacity defined in qcom,ocv-capacity-legend. >> >> Need to specify the sizes of these if not 32-bit. >> >> All these seem to have units, so add unit suffixes as defined in >> property-units.txt. > Should i change code to use microamphours & microvolts or add a new > suffix? It is preferred to use the existing ones unless you have some justification to add new ones. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
