Re: [RFC 05/13] ARM: dts: ti: add support for building .dtb files containing symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/04/18 17:20, Geert Uytterhoeven wrote:
Hi Tero,

On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@xxxxxx> wrote:
Symbols in the DTB files are needed so that overlays can be applied
properly. Add support for building TI SoC specific .dtb files, the
source is fetched from parent directory.

Signed-off-by: Tero Kristo <t-kristo@xxxxxx>

Thanks for your patch!

---
  arch/arm/boot/dts/ti/Makefile | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/ti/Makefile b/arch/arm/boot/dts/ti/Makefile
index b26328b..7d2d411 100644
--- a/arch/arm/boot/dts/ti/Makefile
+++ b/arch/arm/boot/dts/ti/Makefile
@@ -1 +1,6 @@
+DTC_FLAGS += -@ -Wno-reg_format -Wno-avoid_default_addr_size

Why the -W options?

The overlay files typically contain declarations that miss these bits, and will lead to build time warnings. Mostly, because we are working with fragments / references only, and don't have the base declaration available at all.


+
+$(obj)/%.dtb: $(src)/../%.dts FORCE

I guess you want a dependency on $(DTC), too?

Yeah, that should be added actually.


+       $(call if_changed_dep,dtc)
+
  clean-files    += *.dtbo

Gr{oetje,eeting}s,

                         Geert


--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux